The release gate names the baseline-profile task it means
verify.sh --release asked for :baselineprofile:assembleBenchmark, which the baseline-profile plugin made ambiguous when it added a benchmark flavour on top of the benchmark build type - so the task failed before the release build, and the nightly release job has been red without anyone seeing it. The ambiguous name is replaced with assembleBenchmarkBenchmark, with a comment saying why it is spelled out. verify.sh --release is green again.
This commit is contained in:
+4
-2
@@ -50,8 +50,10 @@ if $release; then
|
||||
# No device: this only proves that :benchmark still compiles against the app's benchmark build
|
||||
# type, which is the thing that rots silently between device runs. :baselineprofile is included for
|
||||
# the same reason — its generator only runs on a device with API 33+, so nothing else would notice it
|
||||
# breaking.
|
||||
gradle :app:assembleBenchmark :benchmark:assembleDebug :baselineprofile:assembleBenchmark
|
||||
# breaking. The task is spelled out in full because the baseline-profile plugin adds a `benchmark`
|
||||
# flavour on top of the `benchmark` build type: `assembleBenchmark` is ambiguous between the flavour's
|
||||
# two types, and Gradle refuses it — which is how this line came to be wrong without anything noticing.
|
||||
gradle :app:assembleBenchmark :benchmark:assembleDebug :baselineprofile:assembleBenchmarkBenchmark
|
||||
fi
|
||||
|
||||
printf '\n\033[1mverify: all checks passed\033[0m\n'
|
||||
|
||||
Reference in New Issue
Block a user