From 2690e53662f97be2d0c7f79c1edb88ee35edb7c9 Mon Sep 17 00:00:00 2001 From: Hadrian Burkhardt Date: Sun, 18 Oct 2026 11:21:15 +0200 Subject: [PATCH] The release gate names the baseline-profile task it means verify.sh --release asked for :baselineprofile:assembleBenchmark, which the baseline-profile plugin made ambiguous when it added a benchmark flavour on top of the benchmark build type - so the task failed before the release build, and the nightly release job has been red without anyone seeing it. The ambiguous name is replaced with assembleBenchmarkBenchmark, with a comment saying why it is spelled out. verify.sh --release is green again. --- tools/verify.sh | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/verify.sh b/tools/verify.sh index bd54e90..c900d91 100755 --- a/tools/verify.sh +++ b/tools/verify.sh @@ -50,8 +50,10 @@ if $release; then # No device: this only proves that :benchmark still compiles against the app's benchmark build # type, which is the thing that rots silently between device runs. :baselineprofile is included for # the same reason — its generator only runs on a device with API 33+, so nothing else would notice it - # breaking. - gradle :app:assembleBenchmark :benchmark:assembleDebug :baselineprofile:assembleBenchmark + # breaking. The task is spelled out in full because the baseline-profile plugin adds a `benchmark` + # flavour on top of the `benchmark` build type: `assembleBenchmark` is ambiguous between the flavour's + # two types, and Gradle refuses it — which is how this line came to be wrong without anything noticing. + gradle :app:assembleBenchmark :benchmark:assembleDebug :baselineprofile:assembleBenchmarkBenchmark fi printf '\n\033[1mverify: all checks passed\033[0m\n'