fishfacegit/file-manager
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

The release gate names the baseline-profile task it means

Browse Source 
verify.sh --release asked for :baselineprofile:assembleBenchmark, which the baseline-profile plugin made ambiguous when it added a benchmark flavour on top of the benchmark build type - so the task failed before the release build, and the nightly release job has been red without anyone seeing it. The ambiguous name is replaced with assembleBenchmarkBenchmark, with a comment saying why it is spelled out. verify.sh --release is green again.
This commit is contained in:
Hadrian Burkhardt
2026-10-18 11:21:15 +02:00
parent 51d97dc3ea
commit 2690e53662
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/verify.sh
+4 -2
View File
@@ -50,8 +50,10 @@ if $release; then
# No device: this only proves that :benchmark still compiles against the app's benchmark build # No device: this only proves that :benchmark still compiles against the app's benchmark build
# type, which is the thing that rots silently between device runs. :baselineprofile is included for # type, which is the thing that rots silently between device runs. :baselineprofile is included for
# the same reason — its generator only runs on a device with API 33+, so nothing else would notice it # the same reason — its generator only runs on a device with API 33+, so nothing else would notice it
# breaking. # breaking. The task is spelled out in full because the baseline-profile plugin adds a `benchmark`
gradle :app:assembleBenchmark :benchmark:assembleDebug :baselineprofile:assembleBenchmark # flavour on top of the `benchmark` build type: `assembleBenchmark` is ambiguous between the flavour's
# two types, and Gradle refuses it — which is how this line came to be wrong without anything noticing.
gradle :app:assembleBenchmark :benchmark:assembleDebug :baselineprofile:assembleBenchmarkBenchmark
fi fi
printf '\n\033[1mverify: all checks passed\033[0m\n' printf '\n\033[1mverify: all checks passed\033[0m\n'