From 9a1aa9220b75f944aa843b926671e51b3be74c9c Mon Sep 17 00:00:00 2001 From: Hadrian Burkhardt Date: Thu, 15 Oct 2026 09:52:56 +0200 Subject: [PATCH] Fix the delete confirmation, which still promised permanence Hardware testing caught the dialog saying 1 item will be permanently deleted. This cannot be undone while deletes now stage into the trash. Reworded to describe what actually happens, and deliberately without promising an undo button: that lives in a snackbar and is gone in seconds, whereas the trash keeps the item for a day. Also records that the trash has no screen of its own. --- README.md | 5 +++++ app/src/main/res/values/strings.xml | 11 ++++++++--- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 15528d9..f57d498 100644 --- a/README.md +++ b/README.md @@ -139,6 +139,11 @@ UI.** Translated UI text has to be supplied in `values-/`. ## Known limitations +- **The trash has no screen of its own.** A delete now stages the item in a hidden + `.plainfiles-trash` folder on the same volume and keeps it for 24 hours, and the snackbar + offers Undo. Once that snackbar goes there is no in-app bin to browse or restore from — the + folder is reachable by turning on hidden files, but a proper trash screen is the obvious + follow-up. - **Sharing a file *out* only works in the all-files mode.** A SAF path is relative to the granted tree rather than a filesystem path, so it cannot be handed to `FileProvider`. Receiving a share and being picked from another app's chooser work either way: the first diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 9578885..ec6d5c3 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -114,10 +114,15 @@ File - Delete permanently? + + Move to the trash? - %1$d item will be permanently deleted. This cannot be undone. - %1$d items will be permanently deleted. This cannot be undone. + %1$d item will be moved to the trash, where it is kept for 24 hours before it is removed. + %1$d items will be moved to the trash, where they are kept for 24 hours before they are removed. Items already exist here